To be honest, it depends. Some one-shots are amazing while others aren't. Some long-shots/ chapter fics are also amazing while others just aren't. It all depends on the writer. Also it depends on how long the one-shot is. Just because a fic is longer doesn't make it any better. Same for a shorter fanfic. In my opinion, I prefer and love both x)